Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create JavaScript array without using new keyword. #1987

Merged
merged 7 commits into from
Feb 7, 2020
Merged

Create JavaScript array without using new keyword. #1987

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
53fd377
Create JavaScript array without using `new` keyword.
tpmccallum Feb 3, 2020
29d80a7
Add closing parenthesis to close out self.global
tpmccallum Feb 3, 2020
c496b24
Adding files which were altered by the BLESS=1 system variable. Essen…
tpmccallum Feb 6, 2020
c4b907d
Adding code generated wat file, by way of running tests using BLESS=1
tpmccallum Feb 6, 2020
bdb32bf
Adding table.wat that was generated by running the tests with BLESS=…
tpmccallum Feb 6, 2020
1598da5
Update code that creates heap array line 747 mod.rs
tpmccallum Feb 6, 2020
28572a6
Updating files that are automatically generated when using BLESS=1
tpmccallum Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/anyref-xform/tests/table.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@
(table (;0;) 2 funcref)
(table (;1;) 32 anyref)
(export "func" (table 0))
(elem (;0;) (i32.const 0) $foo $closure0 anyref shim))
(elem (;0;) (i32.const 0) func $foo $closure0 anyref shim))
;)
4 changes: 2 additions & 2 deletions crates/cli-support/src/js/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,8 +744,8 @@ impl<'a> Context<'a> {
return;
}
assert!(!self.config.anyref);
self.global(&format!("const heap = new Array({});", INITIAL_HEAP_OFFSET));
self.global("heap.fill(undefined);");
self.global(&format!("const heap = [];"));
self.global(&format!("heap.length = {};", INITIAL_HEAP_OFFSET));
self.global(&format!("heap.push({});", INITIAL_HEAP_VALUES.join(", ")));
}

Expand Down
2 changes: 1 addition & 1 deletion crates/cli/tests/reference/anyref-empty.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
(type (;0;) (func))
(import "./reference_test.js" "__wbindgen_init_anyref_table" (func (;0;) (type 0)))
(table (;0;) 32 anyref)
(memory (;0;) 17)
(memory (;0;) 16)
(export "memory" (memory 0))
(export "__wbindgen_export_0" (table 0))
(export "__wbindgen_start" (func 0)))
2 changes: 1 addition & 1 deletion crates/cli/tests/reference/empty.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
(module
(memory (;0;) 17)
(memory (;0;) 16)
(export "memory" (memory 0)))
4 changes: 2 additions & 2 deletions crates/cli/tests/reference/import-catch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import * as wasm from './reference_test_bg.wasm';

const heap = new Array(32);
const heap = [];

heap.fill(undefined);
heap.length = 32;

heap.push(undefined, null, true, false);

Expand Down