Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to rename enums (js_name = new_name) #2071

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Add ability to rename enums (js_name = new_name) #2071

merged 2 commits into from
Apr 13, 2020

Conversation

0xd4d
Copy link

@0xd4d 0xd4d commented Apr 6, 2020

Closes #2054

Enables renaming an enum with js_name = "NewName"

@alexcrichton
Copy link
Contributor

Nice! Could a test be added for this too?

@0xd4d
Copy link
Author

0xd4d commented Apr 10, 2020

Test added.

@alexcrichton alexcrichton merged commit 2b12828 into rustwasm:master Apr 13, 2020
@alexcrichton
Copy link
Contributor

👍

@0xd4d 0xd4d deleted the rename_enum branch April 13, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's not possible to js_name rename an enum
3 participants