Fix codegen of consuming setters/getters #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure they reset their internal pointer to null after we call Rust since it invalidates the Rust pointer after being called! Closes rustwasm#2168
Perseus101
pushed a commit
to Perseus101/wasm-bindgen
that referenced
this pull request
Jun 7, 2020
Make sure they reset their internal pointer to null after we call Rust since it invalidates the Rust pointer after being called! Closes rustwasm#2168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure they reset their internal pointer to null after we call Rust
since it invalidates the Rust pointer after being called!
Closes #2168