Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complete WebIDL for ReadableStream #2478

Merged
merged 3 commits into from Apr 15, 2021
Merged

Add complete WebIDL for ReadableStream #2478

merged 3 commits into from Apr 15, 2021

Conversation

DesmondWillowbrook
Copy link
Contributor

Earlier: #2373

To solve: #2252
Found this source, which is the official Streams spec.

@DesmondWillowbrook DesmondWillowbrook marked this pull request as ready for review March 3, 2021 08:46
@alexcrichton
Copy link
Contributor

Thanks for the PR, but I think that this needs to update the generated code for web-sys as well?

@DesmondWillowbrook
Copy link
Contributor Author

Oh sorry, I forgot that part! I'll do it now.

@DesmondWillowbrook DesmondWillowbrook marked this pull request as draft March 15, 2021 17:13
@DesmondWillowbrook
Copy link
Contributor Author

DesmondWillowbrook commented Mar 16, 2021

Hey, so I followed Step 3 in the contributing guide, however, cargo gives the following error:

[~/wasm-bindgen/crates/web-sys]$ cargo run --release --package wasm-bindgen-webidl webidls src/features
error: package(s) `src/features, webidls` not found in workspace `/home/desmond/wasm-bindgen`

@alexcrichton
Copy link
Contributor

I believe that's a bug in Cargo where you need -- after the wasm-bindgen-webidl argument

@DesmondWillowbrook DesmondWillowbrook marked this pull request as ready for review April 15, 2021 06:36
@DesmondWillowbrook
Copy link
Contributor Author

Looks like it's ready to be merged!

@alexcrichton alexcrichton merged commit aa32f4a into rustwasm:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants