Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump #2772

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Version bump #2772

merged 3 commits into from
Jan 19, 2022

Conversation

REllEK-IO
Copy link
Contributor

This is to resolve: #2744
Just need to publish as the current version of wasm-bindgen is from 4 months ago

@REllEK-IO
Copy link
Contributor Author

test: build_examples - is not self referential as its installing the old wasm-bindgen from crates
see line 30 and compare with issue

Looking into the windows test now

@REllEK-IO
Copy link
Contributor Author

`mtKeller@WINDOWS!! ~/projects/wasm-bindgen (main)
$
cargo test --target wasm32-unknown-unknown

Compiling wasm-bindgen-shared v0.2.78 (C:\Users\mtKeller\projects\wasm-bindgen\crates\shared)
Compiling wasm-bindgen v0.2.78 (C:\Users\mtKeller\projects\wasm-bindgen)
Compiling serde_derive v1.0.133
Compiling scoped-tls v1.0.0
Compiling wasm-bindgen-test-macro v0.3.28 (C:\Users\mtKeller\projects\wasm-bindgen\crates\test-macro)
Compiling wasm-bindgen-backend v0.2.78 (C:\Users\mtKeller\projects\wasm-bindgen\crates\backend)
Compiling wasm-bindgen-macro-support v0.2.78 (C:\Users\mtKeller\projects\wasm-bindgen\crates\macro-support)
Compiling wasm-bindgen-macro v0.2.78 (C:\Users\mtKeller\projects\wasm-bindgen\crates\macro)
Compiling js-sys v0.3.55 (C:\Users\mtKeller\projects\wasm-bindgen\crates\js-sys)
Compiling console_error_panic_hook v0.1.7
Compiling wasm-bindgen-test-crate-a v0.1.0 (C:\Users\mtKeller\projects\wasm-bindgen\tests\crates\a)
Compiling wasm-bindgen-test-crate-b v0.1.0 (C:\Users\mtKeller\projects\wasm-bindgen\tests\crates\b)
Compiling wasm-bindgen-futures v0.4.28 (C:\Users\mtKeller\projects\wasm-bindgen\crates\futures)
Compiling wasm-bindgen-test v0.3.28 (C:\Users\mtKeller\projects\wasm-bindgen\crates\test)
warning: static variable document should have an upper case name
--> crates\test\src\rt\browser.rs:20:12
|
20 | static document: HTMLDocument;
| ^^^^^^^^ help: convert the identifier to upper case: DOCUMENT
|
= note: #[warn(non_upper_case_globals)] on by default

warning: wasm-bindgen-test (lib) generated 1 warning
warning: type bar should have an upper camel case name
--> tests\wasm\imports.rs:36:10
|
36 | type bar;
| ^^^ help: convert the identifier to upper camel case: Bar
|
= note: #[warn(non_camel_case_types)] on by default

warning: static variable bar should have an upper case name
--> tests\wasm\duplicates.rs:9:20
|
9 | pub static bar: JsValue;
| ^^^ help: convert the identifier to upper case: BAR
|
= note: #[warn(non_upper_case_globals)] on by default

warning: static variable bar should have an upper case name
--> tests\wasm\duplicates.rs:19:20
|
19 | pub static bar: JsValue;
| ^^^ help: convert the identifier to upper case: BAR

warning: static variable bar should have an upper case name
--> tests\wasm\duplicates.rs:37:20
|
37 | pub static bar: JsValue;
| ^^^ help: convert the identifier to upper case: BAR

warning: static variable bar should have an upper case name
--> tests\wasm\duplicates.rs:47:20
|
47 | pub static bar: JsValue;
| ^^^ help: convert the identifier to upper case: BAR

warning: wasm-bindgen (test "wasm") generated 5 warnings
Finished test [unoptimized + debuginfo] target(s) in 16.80s
Running tests\headless\main.rs (target\wasm32-unknown-unknown\debug\deps\headless-9f669dc9eee61c7c.wasm)
Blocking waiting for file lock on build directory
Compiling winapi v0.3.9
Compiling syn v1.0.85
Compiling leb128 v0.2.5
Compiling num_cpus v1.13.1
Compiling scopeguard v1.1.0
Compiling either v1.6.1
Compiling wasmparser v0.77.0
Compiling libc v0.2.112
Compiling tinyvec_macros v0.1.0
Compiling wit-schema-version v0.1.0
Compiling matches v0.1.9
Compiling safemem v0.3.3
Compiling fastrand v1.6.0
Compiling ppv-lite86 v0.2.16
Compiling unicode-bidi v0.3.7
Compiling itoa v1.0.1
Compiling mime v0.3.16
Compiling chunked_transfer v1.4.0
Compiling wasmparser v0.59.0
Compiling byteorder v1.4.3
Compiling quick-error v1.2.3
Compiling ascii v1.0.0
Compiling base64 v0.13.0
Compiling rustc-demangle v0.1.21
Compiling strsim v0.10.0
Compiling time v0.3.5
Compiling sha1 v0.6.0
Compiling num-traits v0.2.14
Compiling num-integer v0.1.44
Compiling getrandom v0.2.4
Compiling crossbeam-utils v0.8.6
Compiling httparse v1.5.1
Compiling memoffset v0.6.5
Compiling twoway v0.1.8
Compiling tinyvec v1.5.1
Compiling form_urlencoded v1.0.1
Compiling buf_redux v0.8.4
Compiling threadpool v1.8.1
Compiling wit-writer v0.2.0
Compiling wit-parser v0.2.0
Compiling wast v21.0.0
Compiling rand_core v0.6.3
Compiling mime_guess v2.0.3
Compiling base64 v0.9.3
Compiling crossbeam-epoch v0.9.6
Compiling crossbeam-channel v0.5.2
Compiling rand_chacha v0.3.1
Compiling libz-sys v1.1.3
Compiling crossbeam-deque v0.8.1
Compiling rand v0.8.4
Compiling rayon-core v1.9.1
Compiling unicode-normalization v0.1.19
Compiling rayon v1.5.1
Compiling wit-validator v0.2.1
Compiling idna v0.2.3
Compiling url v2.2.2
Compiling id-arena v2.2.1
Compiling wit-text v0.8.0
Compiling remove_dir_all v0.5.3
Compiling chrono v0.4.19
Compiling winapi-util v0.1.5
Compiling curl-sys v0.4.52+curl-7.81.0
Compiling schannel v0.1.19
Compiling atty v0.2.14
Compiling socket2 v0.4.2
Compiling filetime v0.2.15
Compiling termcolor v1.1.2
Compiling tempfile v3.3.0
Compiling multipart v0.18.0
Compiling env_logger v0.8.4
Compiling curl v0.4.42
Compiling tiny_http v0.8.2
Compiling walrus-macro v0.19.0
Compiling serde_derive v1.0.133
Compiling walrus v0.19.0
Compiling wasm-bindgen-wasm-conventions v0.2.78 (C:\Users\mtKeller\projects\wasm-bindgen\crates\wasm-conventions)
Compiling wasm-bindgen-multi-value-xform v0.2.78 (C:\Users\mtKeller\projects\wasm-bindgen\crates\multi-value-xform)
Compiling wit-walrus v0.6.0
Compiling wasm-bindgen-externref-xform v0.2.78 (C:\Users\mtKeller\projects\wasm-bindgen\crates\externref-xform)
Compiling wasm-bindgen-threads-xform v0.2.78 (C:\Users\mtKeller\projects\wasm-bindgen\crates\threads-xform)
Compiling wasm-bindgen-wasm-interpreter v0.2.78 (C:\Users\mtKeller\projects\wasm-bindgen\crates\wasm-interpreter)
Compiling serde v1.0.133
Compiling serde_json v1.0.74
Compiling docopt v1.1.1
Compiling rouille v3.5.0
Compiling wasm-bindgen-cli-support v0.2.78 (C:\Users\mtKeller\projects\wasm-bindgen\crates\cli-support)
Compiling wasm-bindgen-cli v0.2.78 (C:\Users\mtKeller\projects\wasm-bindgen\crates\cli)
Finished dev [unoptimized + debuginfo] target(s) in 49.69s
Running target\debug\wasm-bindgen-test-runner.exe 'C:\Users\mtKeller\projects\wasm-bindgen\target\wasm32-unknown-unknown\debug\deps\headless-9f669dc9eee61c7c.wasm'
Set timeout to 20 seconds...
Running headless tests in Firefox on http://127.0.0.1:53004/
Try find webdriver.json for configure browser's capabilities:
Not found
running 10 tests

test headless::closures_work ... ok
test headless::can_log_html_strings ... ok
test headless::works ... ok
test headless::modules::test_get_five ... ok
test headless::externref_heap_live_count::test_externref_heap_live_count ... ok
test headless::snippets::duplicate_inline_not_unified ... ok
test headless::snippets::test_get_three ... ok
test headless::snippets::stateful_deduplicated ... ok
test headless::snippets::test_get_two ... ok
test headless::strings::string_roundtrip ... ok

test result: ok. 10 passed; 0 failed; 0 ignored
console.log div contained:
<script>alert('lol')</script>

 Running tests\must_use.rs (target\wasm32-unknown-unknown\debug\deps\must_use-f5830ad46d729e36.wasm)
Blocking waiting for file lock on build directory
Finished dev [unoptimized + debuginfo] target(s) in 24.54s
 Running `target\debug\wasm-bindgen-test-runner.exe 'C:\Users\mtKeller\projects\wasm-bindgen\target\wasm32-unknown-unknown\debug\deps\must_use-f5830ad46d729e36.wasm'`

no tests to run!
Running tests\non_wasm.rs (target\wasm32-unknown-unknown\debug\deps\non_wasm-3f250eb7c28a26f8.wasm)
Finished dev [unoptimized + debuginfo] target(s) in 0.20s
Running target\debug\wasm-bindgen-test-runner.exe 'C:\Users\mtKeller\projects\wasm-bindgen\target\wasm32-unknown-unknown\debug\deps\non_wasm-3f250eb7c28a26f8.wasm'
no tests to run!
Running tests\std-crate-no-std-dep.rs (target\wasm32-unknown-unknown\debug\deps\std_crate_no_std_dep-1c9115cadd2a2b8a.wasm)
Finished dev [unoptimized + debuginfo] target(s) in 0.20s
Running target\debug\wasm-bindgen-test-runner.exe 'C:\Users\mtKeller\projects\wasm-bindgen\target\wasm32-unknown-unknown\debug\deps\std_crate_no_std_dep-1c9115cadd2a2b8a.wasm'
no tests to run!
Running tests\unwrap_throw.rs (target\wasm32-unknown-unknown\debug\deps\unwrap_throw-0e0e7e7304120466.wasm)
Finished dev [unoptimized + debuginfo] target(s) in 0.19s
Running target\debug\wasm-bindgen-test-runner.exe 'C:\Users\mtKeller\projects\wasm-bindgen\target\wasm32-unknown-unknown\debug\deps\unwrap_throw-0e0e7e7304120466.wasm'
no tests to run!
Running tests\wasm\main.rs (target\wasm32-unknown-unknown\debug\deps\wasm-26ad8d0d380b0c4c.wasm)
Finished dev [unoptimized + debuginfo] target(s) in 0.20s
Running target\debug\wasm-bindgen-test-runner.exe 'C:\Users\mtKeller\projects\wasm-bindgen\target\wasm32-unknown-unknown\debug\deps\wasm-26ad8d0d380b0c4c.wasm'
Set timeout to 20 seconds...
running 168 tests

test wasm::char::works ... ok
test wasm::comments::works ... ok
test wasm::duplicates::same_function_different_modules ... ok
test wasm::duplicates::same_function_different_locations ... ok
test wasm::validate_prt::works ... ok
test wasm::truthy_falsy::test_is_falsy ... ok
test wasm::truthy_falsy::test_is_truthy ... ok
test wasm::u64::works ... ok
test wasm::api::function_table_is ... ok
test wasm::api::debug_output ... ok
test wasm::api::memory_accessor_appears_to_work ... ok
test wasm::api::null_keeps_working ... ok
test wasm::api::eq_works ... ok
test wasm::api::works ... ok
test wasm::futures::test_promise_err_unit ... ok
test wasm::futures::test_promise_ok_unit ... ok
asdfasdf
test wasm::futures::test_promise_unit ... ok
test wasm::futures::test_promise_err ... ok
test wasm::futures::test_promise_ok ... ok
test wasm::futures::test_promise ... ok
test wasm::futures::smoke ... ok
test wasm::slice::take_clamped ... ok
Received from rust: 0 Uint32Array(9) [
1, 2, 3, 4, 5,
6, 7, 8, 9
]
Received from rust: 1 Uint32Array(9) [
1, 2, 3, 4, 5,
6, 7, 8, 9
]
Received from rust: 2 Uint32Array(9) [
1, 2, 3, 4, 5,
6, 7, 8, 9
]
Received from rust: 3 Uint32Array(9) [
1, 2, 3, 4, 5,
6, 7, 8, 9
]
Received from rust: 4 Uint32Array(9) [
1, 2, 3, 4, 5,
6, 7, 8, 9
]
Received from rust: 5 Uint32Array(9) [
1, 2, 3, 4, 5,
6, 7, 8, 9
]
Received from rust: 6 Uint32Array(9) [
1, 2, 3, 4, 5,
6, 7, 8, 9
]
Received from rust: 7 Uint32Array(9) [
1, 2, 3, 4, 5,
6, 7, 8, 9
]
Received from rust: 8 Uint32Array(9) [
1, 2, 3, 4, 5,
6, 7, 8, 9
]
Received from rust: 9 Uint32Array(9) [
1, 2, 3, 4, 5,
6, 7, 8, 9
]
test wasm::slice::return_vec ... ok
Int8Array(3) [ 1, 2, 3 ]
Int8Array(3) [ 4, 5, 3 ]
Uint8Array(3) [ 1, 2, 3 ]
Uint8Array(3) [ 4, 5, 3 ]
Int16Array(3) [ 1, 2, 3 ]
Int16Array(3) [ 4, 5, 3 ]
Uint16Array(3) [ 1, 2, 3 ]
Uint16Array(3) [ 4, 5, 3 ]
Int32Array(3) [ 1, 2, 3 ]
Int32Array(3) [ 4, 5, 3 ]
Uint32Array(3) [ 1, 2, 3 ]
Uint32Array(3) [ 4, 5, 3 ]
Int32Array(3) [ 1, 2, 3 ]
Int32Array(3) [ 4, 5, 3 ]
Uint32Array(3) [ 1, 2, 3 ]
Uint32Array(3) [ 4, 5, 3 ]
Float32Array(3) [ 1, 2, 3 ]
Float32Array(3) [ 4, 5, 3 ]
Float64Array(3) [ 1, 2, 3 ]
Float64Array(3) [ 4, 5, 3 ]
test wasm::slice::export_mut ... ok
test wasm::slice::import_mut ... ok
test wasm::slice::pass_array ... ok
test wasm::slice::import ... ok
test wasm::slice::export ... ok
test wasm::final_::classes ... ok
test wasm::final_::simple ... ok
test wasm::no_shims::no_shims ... ok
test wasm::node::works ... ok
undefined undefined
10 10
test wasm::duplicate_deps::works ... ok
test wasm::simple::externref_heap_live_count ... ok
test wasm::simple::string_roundtrip ... ok
test wasm::simple::renaming_imports_and_instanceof ... ok
test wasm::simple::optional_slices ... ok
test wasm::simple::binding_to_unimplemented_apis_doesnt_break_everything ... ok
test wasm::simple::jsvalue_typeof ... ok
test wasm::simple::other_exports ... ok
test wasm::simple::wrong_types ... ok
test wasm::simple::return_a_string ... ok
test wasm::simple::string_arguments ... ok
test wasm::simple::add ... ok
test wasm::getters_and_setters::setter_compute ... ok
test wasm::getters_and_setters::getter_compute ... ok
test wasm::getters_and_setters::_13_rust ... ok
test wasm::getters_and_setters::_12_rust ... ok
test wasm::getters_and_setters::_11_rust ... ok
test wasm::getters_and_setters::_10_rust ... ok
test wasm::getters_and_setters::_9_rust ... ok
test wasm::getters_and_setters::_8_rust ... ok
test wasm::getters_and_setters::_7_rust ... ok
test wasm::getters_and_setters::_6_rust ... ok
test wasm::getters_and_setters::_5_rust ... ok
test wasm::getters_and_setters::_4_rust ... ok
test wasm::getters_and_setters::_3_rust ... ok
test wasm::getters_and_setters::_2_rust ... ok
test wasm::getters_and_setters::_1_rust ... ok
test wasm::variadic::rest_vec ... ok
test wasm::variadic::f64 ... ok
test wasm::variadic::f32 ... ok
test wasm::variadic::i32 ... ok
test wasm::variadic::i16 ... ok
test wasm::variadic::i8 ... ok
test wasm::variadic::u32 ... ok
test wasm::variadic::u16 ... ok
test wasm::variadic::u8 ... ok
test wasm::arg_names::rust_arg_names ... ok
test wasm::import_class::nested_namespace ... ok
test wasm::import_class::static_structural ... ok
test wasm::import_class::catch_constructors ... ok
test wasm::import_class::options ... ok
test wasm::import_class::rename_setter_getter ... ok
test wasm::import_class::properties ... ok
test wasm::import_class::rename_type ... ok
test wasm::import_class::new_constructors ... ok
test wasm::import_class::construct ... ok
test wasm::import_class::import_class ... ok
test wasm::import_class::simple ... ok
test wasm::vendor_prefix::polyfill_works ... ok
test wasm::enums::test_renamed_enum ... ok
test wasm::enums::test_optional_enum_values ... ok
test wasm::enums::test_optional_enums ... ok
test wasm::enums::c_style_enum_with_custom_values ... ok
test wasm::enums::c_style_enum ... ok
test wasm::option::import_by_ref ... ok
test wasm::option::export_by_value ... ok
test wasm::option::import_by_value ... ok
test wasm::math::limits_correct ... ok
test wasm::math::auto_bind_math ... ok
test wasm::js_objects::another_vector_string_return ... ok
test wasm::js_objects::returning_vector_string ... ok
test wasm::js_objects::another_vector_return ... ok
test wasm::js_objects::returning_vector ... ok
test wasm::js_objects::promote ... ok
test wasm::js_objects::clone ... ok
test wasm::js_objects::owned ... ok
test wasm::js_objects::simple ... ok
test wasm::classes::inspectable_classes_can_override_generated_methods ... ok
test wasm::classes::inspectable_classes ... ok
test wasm::jscast::multiple_layers_of_inheritance ... ok
test wasm::jscast::method_calling ... ok
test wasm::jscast::casting ... ok
test wasm::jscast::instanceof_works ... ok
test wasm::result::test_option ... ok
test wasm::result::test_unit ... ok
test wasm::result::test_enum_err ... ok
test wasm::result::test_enum_ok ... ok
test wasm::result::test_string_err ... ok
test wasm::result::test_string_ok ... ok
test wasm::result::test_jsvalue_err ... ok
test wasm::result::test_jsvalue_ok ... ok
test wasm::result::test_return_string ... ok
test wasm::result::test_struct ... ok
test wasm::result::test_ok ... ok
test wasm::result::test_err ... ok

test result: ok. 168 passed; 0 failed; 0 ignored

mtKeller@WINDOWS11 ~/projects/wasm-bindgen (main)`

@alexcrichton
Copy link
Contributor

Thanks for the PR! For version bumps though this requires running ./publish bump after compilling the publish.rs script in this repo. Can you also add an entry to CHANGELOG.md for the release date?

@REllEK-IO
Copy link
Contributor Author

My pleasure, thank you all for your hard work.

@wenzhang-dev
Copy link

wasm-bindgen maybe version-0.2.78 is incompatible with version-0.2.79, when I use asnycify for await/async.
but i cannot fix it. So I eventually went back to old version, everything becomes fine.

@REllEK-IO
Copy link
Contributor Author

REllEK-IO commented Jan 25, 2022

@MichealZwen Can you provide a test case/error log?

Watching #2776

@wenzhang-dev
Copy link

@mtKeller Sorry, there's too much detail.
can you provide the update lists from 0.2.78 to 0.2.79?

Basically what I did was compile c/c ++ programs into WebAssembly via Emscripten and package them into static libraries. Finally rust links to the static library and binds javascript interfaces using wasm-bindgen.

As it turns out, the pure Rust version is fine. But c/c ++ programs using Asyncify failed the tescases in 0.2.79.

@REllEK-IO
Copy link
Contributor Author

I'll see about doing a test. Version bump was a release of all changes from September to current. So there is a bit a room for something to break

0.2.78...0.2.79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cant compile
3 participants