-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version bump #2772
Version bump #2772
Conversation
test: build_examples - is not self referential as its installing the old wasm-bindgen from crates Looking into the windows test now |
`mtKeller@WINDOWS!! ~/projects/wasm-bindgen (main) Compiling wasm-bindgen-shared v0.2.78 (C:\Users\mtKeller\projects\wasm-bindgen\crates\shared) warning: warning: static variable warning: static variable warning: static variable warning: static variable warning: test headless::closures_work ... ok test result: ok. 10 passed; 0 failed; 0 ignored
no tests to run! test wasm::char::works ... ok test result: ok. 168 passed; 0 failed; 0 ignored mtKeller@WINDOWS11 ~/projects/wasm-bindgen (main)` |
Thanks for the PR! For version bumps though this requires running |
My pleasure, thank you all for your hard work. |
wasm-bindgen maybe version-0.2.78 is incompatible with version-0.2.79, when I use asnycify for await/async. |
@MichealZwen Can you provide a test case/error log? Watching #2776 |
@mtKeller Sorry, there's too much detail. Basically what I did was compile c/c ++ programs into WebAssembly via Emscripten and package them into static libraries. Finally rust links to the static library and binds javascript interfaces using wasm-bindgen. As it turns out, the pure Rust version is fine. But c/c ++ programs using Asyncify failed the tescases in 0.2.79. |
I'll see about doing a test. Version bump was a release of all changes from September to current. So there is a bit a room for something to break |
This is to resolve: #2744
Just need to publish as the current version of wasm-bindgen is from 4 months ago