Remove redundant unit expressions to calm clippy #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egfx-notifications
added a commit
to egfx-notifications/wasm-minisign-verify
that referenced
this pull request
Mar 4, 2022
wasm-bindgen 0.2.79 introduced a change in code generation that makes clippy complain A fix has already been merged to main (rustwasm/wasm-bindgen#2778) but we have to wait for the next official release to make use of it. Once we update to the new wasm-bindgen with the fix we should remove this workaround!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2774
After the code generation of the macro
wasm_bindgenclippy sees a lot of explicit()at the ends of blocks.I removed them in
codegen.rs, because imho it is clear enough that these blocks don't return anything because of the expressionsconst #some_name: () = {before these blocks.