Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli-support): expose more data on Output #2913

Merged
merged 1 commit into from May 26, 2022

Conversation

dsherret
Copy link
Contributor

@dsherret dsherret commented May 25, 2022

This is to be able to use the output in memory more than what's already available.

(I'm using the cli-support crate in Wasm so that we can build everything via a Deno script without needing to install wasm-bindgen globally)

Copy link
Collaborator

@hamza1311 hamza1311 left a comment

The changes look good to me. I like to provide the ability to ability to avoid a global binary install.

(I'm using the cli-support crate in Wasm so that we can build everything via a Deno script without needing to install wasm-bindgen globally)

I'm concerned about recommending what you're trying to do though. That sounds like a disaster incoming because of version mismatch between the cli-support crate and wasm-bindgen crate used in the binary. If that is irrelevant (it's totally possible I'm totally misunderstanding your use-case), it would be nice if you could clarify what it is that you're trying achieve.

@hamza1311 hamza1311 merged commit be961ac into rustwasm:main May 26, 2022
21 checks passed
@dsherret dsherret deleted the more_data_output branch May 26, 2022
@dsherret
Copy link
Contributor Author

@dsherret dsherret commented May 26, 2022

I'm concerned about recommending what you're trying to do though. That sounds like a disaster incoming because of version mismatch between the cli-support crate and wasm-bindgen crate used in the binary. If that is irrelevant (it's totally possible I'm totally misunderstanding your use-case), it would be nice if you could clarify what it is that you're trying achieve.

Are you talking about the mismatch between the wasm-bindgen crate used in the .wasm file and wasm-bindgen-cli-support? I'm planning on analyzing the cargo manifest of the crate and only supporting the specific version of wasm-bindgen that the cli-support crate is for. I already found the mismatch between the global wasm-bindgen-cli and wasm-bindgen to sometimes give very cryptic errors (though maybe that's been fixed now) so at least this way we can ensure everyone is on the same version of wasm-bindgen-cli-support because it will be built into the script.

expenses pushed a commit to expenses/wasm-bindgen that referenced this issue Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants