Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't attempt to initialise memory views before the wasm module is initialised in the bunder target #2965

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Don't attempt to initialise memory views before the wasm module is initialised in the bunder target #2965

merged 1 commit into from
Jun 27, 2022

Commits on Jun 27, 2022

  1. Fixes rustwasm#2961 

    In the bundler target, there's a circular dependency between the bindings and the wasm module. That means that the wasm module's exports aren't available at the top level. In rustwasm#2886, I didn't realise that and made the memory views be initialised at the top level, which resulted in an error from the wasm module's memory not being available yet.

This fixes that by lazily initialising the memory views like they were before rustwasm#2886, except that they're reset to uninitialised in `init` to make sure they're updated if it's called multiple times (the reason I made them be immediately initialised in the first place).
    @Liamolucko
    Liamolucko committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    4c063fc View commit details
    Browse the repository at this point in the history