Handle precompiled modules in initSync on target web #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaslihotzki
force-pushed
the
precompiled-initsync
branch
from
3244660
to
fb1fda9
Compare
Liamolucko
reviewed
Aug 3, 2022
lukaslihotzki
force-pushed
the
precompiled-initsync
branch
from
fb1fda9
to
bca8308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the default init can handle a variety of possible input types, initSync currently needs a BufferSource. With this change, initSync can also accept a WebAssembly.Module, so it is more consistent to default init.
This may be useful for workers and worklets when the compiled module is reused and blocking the thread is acceptable.