Better BigInt conversions #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some [iu](64|128) intrinsics to convert large numbers to JsValue directly, without stringifying and parsing them back. Also adding a few more tests as previously those conversions didn't have any test coverage.
Liamolucko
reviewed
Aug 31, 2022
Liamolucko
approved these changes
Aug 31, 2022
RReverser
added a commit
to RReverser/serde-wasm-bindgen
that referenced
this pull request
Sep 1, 2022
As of rustwasm/wasm-bindgen#3049 the builtin conversions no longer use strings, but pass numbers directly, so our custom intrinsic is no longer necessary.
RReverser
added a commit
to RReverser/serde-wasm-bindgen
that referenced
this pull request
Sep 1, 2022
As of rustwasm/wasm-bindgen#3049 the builtin conversions no longer use strings, but pass numbers directly, so our custom intrinsic is no longer necessary.
RReverser
added a commit
to RReverser/serde-wasm-bindgen
that referenced
this pull request
Sep 1, 2022
As of rustwasm/wasm-bindgen#3049 the builtin conversions no longer use strings, but pass numbers directly, so our custom intrinsic is no longer necessary.
RReverser
added a commit
to RReverser/serde-wasm-bindgen
that referenced
this pull request
Sep 1, 2022
As of rustwasm/wasm-bindgen#3049 the builtin conversions no longer use strings, but pass numbers directly, so our custom intrinsic is no longer necessary.
This was referenced Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some
[iu](64|128)intrinsics to convert large numbers toJsValuedirectly, without stringifying and parsing them back.Also adding a few more tests as previously those conversions didn't have any test coverage.