feat(#3843): Add support for CanvasState.reset #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Nul-led
commented
Feb 10, 2024
Nul-led
commented
- Resolves issue Missing implementation of reset method on CanvasRenderingContext2D and OffscreenCanvasRenderingContext2d #3843
- Documented method according to https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/reset
|
@daxpedda would be nice if you could review :) |
|
Not exactly sure if i need to put a notice into the changelog. Ill leave it at this for now. |
|
Ok with that, its ready for review now i think |
daxpedda
requested changes
Feb 10, 2024
|
@daxpedda good enough? |
daxpedda
reviewed
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.