Fix consuming a struct and returning a slice #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
force-pushed
the
consume-ret-string
branch
from
1dcfd35
to
34ef5ba
Compare
This came up in a [recent comment][1] and it turns out we're accidentally generating two `const ptr = ...` declarations, invalid JS! While Node doesn't catch this it looks like firefox does. [1]: rustwasm#329 (comment)
alexcrichton
force-pushed
the
consume-ret-string
branch
from
34ef5ba
to
0d18c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in a recent comment and it turns out we're accidentally
generating two
const ptr = ...declarations, invalid JS! While Node doesn'tcatch this it looks like firefox does.