Fix web-sys build on some Windows builds #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The official pathname separator on Windows is `\` instead of `/`, but we've been unconditionally using `/`. This typically works on Windows because Cargo's default `OUT_DIR` listing is a normal `C:\...` path which works with either `/` or `\`. If, however, a user sets `CARGO_TARGET_DIR` to a UNC-style path like `\\?\C:\...` then `/` is *not* the same as `\`, but rather `/` is interpreted as part of the file name (to allow file names with `/` in the name). Let's bypass all this and just use a build script output env var. Closes rustwasm#943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official pathname separator on Windows is
\instead of/, butwe've been unconditionally using
/. This typically works on Windowsbecause Cargo's default
OUT_DIRlisting is a normalC:\...pathwhich works with either
/or\. If, however, a user setsCARGO_TARGET_DIRto a UNC-style path like\\?\C:\...then/isnot the same as
\, but rather/is interpreted as part of the filename (to allow file names with
/in the name).Let's bypass all this and just use a build script output env var.
Closes #943