Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write a log with all the stout/sterr #50

Closed
ashleygwilliams opened this issue Mar 13, 2018 · 4 comments · Fixed by #134
Closed

write a log with all the stout/sterr #50

ashleygwilliams opened this issue Mar 13, 2018 · 4 comments · Fixed by #134
Labels
to-do stuff that needs to happen, so plz do it k thx
Milestone

Comments

@ashleygwilliams
Copy link
Member

ashleygwilliams commented Mar 13, 2018

#49 turned off all the stdout/err fwding. this output is still useful for debugging when people run into issues, so let's write it to a wasm-pack-debug.log

@ashleygwilliams ashleygwilliams added the to-do stuff that needs to happen, so plz do it k thx label Mar 13, 2018
@ashleygwilliams ashleygwilliams added this to the 0.1.0 milestone Mar 13, 2018
@mgattozzi
Copy link
Contributor

Some clarifying questions:

  • Where do we want to store this log? Linux, Windows, and OSX would likely have different places
  • We also want to utilize the verbosity setting as well so we want it to be able to log to the CLI as well yes?

@ashleygwilliams
Copy link
Member Author

re the location, i was thinking we'd copy what npm does which is a wasmpack-debug.log in the root of the pkg (in our case the crate, which is default . or whatever path is passed)

and yes yes, verbosity settings please

@ashleygwilliams ashleygwilliams modified the milestones: 0.1.0, 0.3.0 Apr 18, 2018
@mgattozzi
Copy link
Contributor

Okay that sounds good to me. We should probably automatically add the log to the .gitignore if it's not already there so it doesn't get comitted.

cool so in terms of verbosity levels something like:

No flag = error, warn, info
-v = error, warn, info, debug
-vv = error, warn, info, debug, trace

Do we want the log appended too by default or overwrite each time? I would think append with some kind of delimeter for each run

@data-pup
Copy link
Member

I’d love to help out with this one 🙂 I can start looking into it this weekend!

@mgattozzi mgattozzi mentioned this issue May 29, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants