Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): improve output messaging #49

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Conversation

ashleygwilliams
Copy link
Member

fixes #39, #44, #46

src/main.rs Outdated
readme::copy_from_crate(&crate_path)?;
println!(
"{} {}Installing WASM-bindgen...",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can make this an optional thing at some point? like if it's installed we just do 6 things rather than 7. But that's like a future improvement and not something that needs to be done now and block 0.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so currently, if wasm-bindgen is already installed this step doesn't actually do anything (it actually fails and yells in stderr). we should def check if it's installed and just skip if it is... both this and adding the target should just not happen if they are already present.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case the numbering will also need to be dynamically done rather than it being hardcoded. Maybe a step at the beginning to calculate what can be done without then run the rest.

@mgattozzi
Copy link
Contributor

This is all very nice and much easier to see where things are happening :D

@ashleygwilliams ashleygwilliams force-pushed the pretty-output branch 2 times, most recently from e03fca6 to d2d07d5 Compare March 13, 2018 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup tool messaging output
2 participants