Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass --target web to wasm-bindgen instead of --web #597

Closed
alexcrichton opened this issue Mar 22, 2019 · 5 comments
Closed

Pass --target web to wasm-bindgen instead of --web #597

alexcrichton opened this issue Mar 22, 2019 · 5 comments
Labels
current release current todo items needs discussion to-do stuff that needs to happen, so plz do it k thx
Milestone
0.9.0

Comments

@alexcrichton
Copy link
Contributor

This is intended to be a tracking issue for integration rustwasm/wasm-bindgen#1369 fully into wasm-pack. That PR to wasm-bindgen "deprecated" old target flags like --web, --no-modules, etc. The deprecated flags are still accepted without warning, but all documentation shoul ideally point towards --target now.

Currently wasm-pack passes the old flags for --web and such, and I think that it will want to continue doing so for the near future as well. Once enough users have upgraded wasm-bindgen and older versions start getting naturally phased out, we'll want to switch wasm-pack to passing down the --target flag as well (probably just passing it through directly to wasm-bindgen).
@alexcrichton alexcrichton mentioned this issue Mar 22, 2019
Merged
@ashleygwilliams

This comment has been minimized.

Sign in to view
@nicksrandall

This comment has been minimized.

Sign in to view
@gameldar gameldar mentioned this issue Apr 29, 2019
Closed
@ashleygwilliams
Copy link
Member

we should update wasm-pack to use the new --target flag here: https://github.com/rustwasm/wasm-pack/blob/master/src/bindgen.rs#L44

@ashleygwilliams ashleygwilliams added current release current todo items to-do stuff that needs to happen, so plz do it k thx labels Jul 16, 2019
@ashleygwilliams ashleygwilliams added this to the 0.9.0 milestone Jul 16, 2019
This was referenced Jul 16, 2019
Closed
Merged
@ashleygwilliams
Copy link
Member

version this was released in was 0.2.40

@ashleygwilliams
Copy link
Member

clsoed by #682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
current release current todo items needs discussion to-do stuff that needs to happen, so plz do it k thx
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
3 participants
@alexcrichton @ashleygwilliams @nicksrandall