Replace target flags with --target
#1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had this idea when reviewing docs recently and was curious what others though, this is a pretty big change though, so if y'all think an RFC is requested I don't mind doing that. |
This commit deprecates the `--web`, `--no-modules`, and `--nodejs` flags in favor of one `--target` flag. The motivation for this commit is to be consistent between `wasm-bindgen` and `wasm-pack` so documentation for one is applicable for the other (so we don't have to document everywhere what the translation is between flags). Additionally this should make it a bit easier to add new targets (if necessary) in the future as it won't add to the proliferation of flags. For now the old flags (like `--web`) continue to be accepted, but they'll be removed during the next set of breaking changes for `wasm-bindgen`.
|
@alexcrichton this is great. we should chat about the deprecation plan as wasm-pack will have to do a bit of dance around how it supports older wasm-bindgen versions (or alternatively we'll need to do a check that the wasm-bindgen version isn't too old.) not to hard but commenting here to flag so i remember to keep an eye on this! |
|
I've filed rustwasm/wasm-pack#597 to track this as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deprecates the
--web,--no-modules, and--nodejsflagsin favor of one
--targetflag. The motivation for this commit is to beconsistent between
wasm-bindgenandwasm-packso documentation forone is applicable for the other (so we don't have to document everywhere
what the translation is between flags). Additionally this should make it
a bit easier to add new targets (if necessary) in the future as it won't
add to the proliferation of flags.
For now the old flags (like
--web) continue to be accepted, butthey'll be removed during the next set of breaking changes for
wasm-bindgen.