More logging and assertions #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@fitzgen do we want to put panics in or would we prefer to propagate an error (just in case it's someone who is not us who runs into this...) i'm OK with either, maybe slightly prefer error?
|
looks like CI wants the lockfile updated :) |
Instead of panicking on unexpected states, check for them and return an error. Also add more debug logging for when we `cargo install` wasm-bindgen.
fitzgen
force-pushed
the
more-logging-and-assertions
branch
from
abb7d74
to
8325d9a
Compare
|
The assertion was slightly off too -- |
|
now CI is failing on missing wasm-bindgen.exe :/ |
ashleygwilliams
changed the title
|
Assuming CI comes back green, this should be ready. |
ashleygwilliams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some logging and assertions to help us figure out what is going on with #503 when a
cargo installisn't working right.I can't repro #503 anymore, but this should help us if we ever see it in the wild again :-/