Allow any type as the key type in records #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#39 (comment) is something I wrote... wow over a year ago. This isn't really a maintained library any more insofar that web-sys is "done". If you'd like though if you're actively using this we can probably arrange for a repo transfer. |
RSSchermer
added a commit
to RSSchermer/wasm-bindgen
that referenced
this pull request
May 20, 2022
In response to rustwasm/weedle#50
alexcrichton
pushed a commit
to rustwasm/wasm-bindgen
that referenced
this pull request
May 23, 2022
* Update weedle dependency to git dependency As discussed in rustwasm/weedle#52 (comment) * Change `StringType` to `RecordKeyType` In response to rustwasm/weedle#50 * Accommodate constants in namespaces See rustwasm/weedle#52 * Reformat with rust-fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over at mozilla/uniffi-rs we use Weedle to parse UDL, which really is just WebIDL with a couple more annotations.
Weedle supports most things we need already.
But this PR here is one thing we might want to have: non-string keys for records.
It seemed easy enough to allow any type by just nesting the parsers (of course for our usecase we will need to restrict that again because keys still need to be hashable ultimately).
Would you consider this change for Weedle?