Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gzip #30

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Gzip #30

wants to merge 6 commits into from

Conversation

dhardy
Copy link

@dhardy dhardy commented Jul 28, 2014

This adds gzip decompression support.

You probably don't want to include as-is; I'm using Rust 0.11.0. I'm also using Meson to compile (Cargo didn't work; maybe the old version), which required renaming a couple of files (Meson's Rust support is in its infancy).

Code review is also welcome. I've tested against a few gzip examples (included).

@kvark
Copy link
Collaborator

kvark commented Jul 29, 2014

This is grand! I've scanned through it and didn't see anything inherently wrong. Would be nice to have it merging/compiling successfully, and then I'd do a second pass.

@dhardy
Copy link
Author

dhardy commented Jul 29, 2014

Yes, merging would be nice. I beg to differ, though: it does compile
successfully. If I update my Rust installation I'll update the code, but that
may not happen immediately.

On a slightly different topic, I notice it's a lot slower than the official
"gunzip". How does one go about profiling Rust code?

On Monday 28 July 2014 18:16:32 Dzmitry Malyshau wrote:

This is grand! I've scanned through it and didn't see anything inherently
wrong. Would be nice to have it merging/compiling successfully, and then
I'd do a second pass.


Reply to this email directly or view it on GitHub:
#30 (comment)

@alexcrichton
Copy link
Collaborator

Sadly the zlib decoder is not optimized at all, and is likely quite slow. You may be interested in the gzip bindings I wrote for another project which is backed by miniz.c for decompression/compression.

@dhardy
Copy link
Author

dhardy commented Jul 30, 2014

Write support too. Wish I'd known this existed before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants