Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails with latest PyTorch nightly - THRandom has been removed #22

Closed
Dawars opened this issue Jun 13, 2019 · 1 comment · Fixed by #23
Closed

Build fails with latest PyTorch nightly - THRandom has been removed #22

Dawars opened this issue Jun 13, 2019 · 1 comment · Fixed by #23

Comments

@Dawars
Copy link
Contributor

Dawars commented Jun 13, 2019

Build fails with the latest PyTorch nightly, saying:

cpu/sampler.cpp:1:10: fatal error: TH/THRandom.h: No such file or directory

     #include <TH/THRandom.h>

              ^~~~~~~~~~~~~~~

THRandom was removed in: https://github.com/pytorch/pytorch/pull/21364/files#diff-f5b62748ce692072a882105cff893616L14
Dawars added a commit to Dawars/pytorch_cluster that referenced this issue Jun 13, 2019
@Dawars
Fixes breakage with PyTorch nightly rusty1s#22
1088c64 
This PR is supposed to fix issue rusty1s#22

Replaces THRandom with the new CPUGenerator
Dawars added a commit to Dawars/pytorch_cluster that referenced this issue Jun 13, 2019
@Dawars
Fixes breakage with PyTorch nightly rusty1s#22
88a60c4
@Dawars Dawars mentioned this issue Jun 13, 2019
Merged
@rusty1s
Copy link
Owner

rusty1s commented Jun 13, 2019

Thank you for the PR!

@rusty1s rusty1s closed this as completed Jun 13, 2019
rusty1s added a commit that referenced this issue Jun 14, 2019
@rusty1s
Merge pull request #23 from Dawars/patch-2
e465ac0 
Fixes breakage with PyTorch nightly #22
@acharkq acharkq mentioned this issue Mar 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes breakage with PyTorch nightly #22 Dawars/pytorch_cluster
2 participants
@Dawars @rusty1s