Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #50

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Update readme #50

merged 1 commit into from
Feb 7, 2020

Conversation

mdiephuis
Copy link
Contributor

Fixed a tiny error in the random walk example output.

Fixed a tiny error in the random walk example output.
@rusty1s
Copy link
Owner

rusty1s commented Feb 7, 2020

Hi and thank you, but the random walk output is non-deterministic, so both variants should be correct :)

@codecov-io
Copy link

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files           8        8           
  Lines         141      141           
=======================================
  Hits          140      140           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ebb1d...506f4f2. Read the comment docs.

@mdiephuis
Copy link
Contributor Author

Ok, I just expected the number of returned walks, or size(0) of the returned tensor to be identical in number to the number of indices passed in start.

@rusty1s
Copy link
Owner

rusty1s commented Feb 7, 2020

Oh, you are right. This is an error!

@rusty1s rusty1s merged commit 0194ebb into rusty1s:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants