Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pointnet++ part segmentation example #285

Merged
merged 3 commits into from
May 15, 2019
Merged

Conversation

dragonbook
Copy link
Contributor

@dragonbook dragonbook commented May 9, 2019

Hi, @rusty1s

This is a pointnet++ part segmentation example as I mentioned at issue141. Sorry for the delay and my poor code comment.

@rusty1s
Copy link
Member

rusty1s commented May 9, 2019

Really cool. I will have a closer look next week. Sorry for the delay.

@dragonbook
Copy link
Contributor Author

dragonbook commented May 15, 2019

I tested the implementation on shapenet, and it can perform well.

@rusty1s
Copy link
Member

rusty1s commented May 15, 2019

Hi, I tested it myself and it runs great. You rock. There are a few things I would do differently (like outsourcing some functionality to PyG, e.g., IoU computation), but I can do this in the master branch. Again, thank you so much for your valuable contribution.

@rusty1s rusty1s merged commit 08f98cf into pyg-team:master May 15, 2019
rusty1s added a commit that referenced this pull request Jun 29, 2019
add pointnet++ part segmentation example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants