Enable index_sort
#306
Merged
Enable index_sort
#306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamianSzwichtenberg
force-pushed
the
enable-index-sort
branch
2 times, most recently
from
e3e5b99
to
1270d99
Compare
|
@rusty1s @mszarma @JakubPietrakIntel Please take a look. |
rusty1s
added a commit
to pyg-team/pytorch_geometric
that referenced
this pull request
Feb 1, 2023
Enable `index_sort` introduced in [pyg-lib](https://pyg-lib.readthedocs.io/en/latest/modules/ops.html#pyg_lib.ops.index_sort). Till now, sorting indices (1d tensor) have been working sequentially. This PR enables the `index_sort` operation, which makes such a sort work in parallel (parallelized radix sort). Related PR: [pytorch_sparse:306](rusty1s/pytorch_sparse#306) In training benchmarks, data set load time was improved on average by 3.82 times, and training time by 1.06 times. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
|
@rusty1s One PR left to go 😉 |
Indeed, will merge tomorrow :D |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #306 +/- ##
==========================================
- Coverage 72.54% 72.50% -0.05%
==========================================
Files 28 29 +1
Lines 1122 1131 +9
==========================================
+ Hits 814 820 +6
- Misses 308 311 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
index_sortintroduced in pyg-lib.Related PR: pytorch_geometric:6554