Fix cmake abosule paths in build interface #331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLOB creates absolute paths requiring the BUILD_INTERFACE generator to be placed inside quotes.
Currently, here is what the autogenerated
TorchSparseTargets.cmake
looks like:This causes an error when the
TorchSparse::TorchSparse
is added to other projects because of the absolute path.Adding quotes to the generator in CMakeLists.txt fixes this issue.