Avoid inserting multiple locks if a lock already exists (knex#4694)

rustyconover · Oct 18, 2021 · 6cf68ba · 6cf68ba
1 parent e4bd9b9
commit 6cf68ba
Showing 1 changed file with 12 additions and 3 deletions.
diff --git a/lib/migrations/migrate/table-creator.js b/lib/migrations/migrate/table-creator.js
@@ -7,7 +7,6 @@ const {
 
 function ensureTable(tableName, schemaName, trxOrKnex) {
   const lockTable = getLockTableName(tableName);
-  const lockTableWithSchema = getLockTableNameWithSchema(tableName, schemaName);
   return getSchemaBuilder(trxOrKnex, schemaName)
     .hasTable(tableName)
     .then((exists) => {
@@ -26,8 +25,7 @@ function ensureTable(tableName, schemaName, trxOrKnex) {
     })
     .then((data) => {
       return (
-        !data.length &&
-        trxOrKnex.into(lockTableWithSchema).insert({ is_locked: 0 })
+        !data.length && _insertLockRowIfNeeded(tableName, schemaName, trxOrKnex)
       );
     });
 }
@@ -54,6 +52,17 @@ function _createMigrationLockTable(tableName, schemaName, trxOrKnex) {
   );
 }
 
+function _insertLockRowIfNeeded(tableName, schemaName, trxOrKnex) {
+  const lockTableWithSchema = getLockTableNameWithSchema(tableName, schemaName);
+  return trxOrKnex
+    .from(trxOrKnex.raw('?? (??)', [lockTableWithSchema, 'is_locked']))
+    .insert(function () {
+      return this.select(trxOrKnex.raw('?', [0])).whereNotExists(function () {
+        return this.select('*').from(lockTableWithSchema);
+      });
+    });
+}
+
 //Get schema-aware schema builder for a given schema nam
 function getSchemaBuilder(trxOrKnex, schemaName) {
   return schemaName