Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update pdm-project/setup-pdm action to v4 #1963

Merged
merged 1 commit into from
Jun 22, 2024
Merged

chore(deps): update pdm-project/setup-pdm action to v4 #1963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
- name: Set up PDM
uses: pdm-project/setup-pdm@ddc33ca746b5716353581f988b29464200212702 # v3
uses: pdm-project/setup-pdm@568ddd69406b30de1774ec0044b73ae06e716aa4 # v4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action 'pdm-project/setup-pdm' has been updated from version 3 to version 4. Ensure that this version change doesn't cause any breaking changes. Please validate this with some test runs before merging it into the main branch.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pdm-project/setup-pdm action was updated from version 3 (ddc33ca746b5716353581f988b29464200212702) to version 4 (568ddd69406b30de1774ec0044b73ae06e716aa4). This could result in improvements like new features or bug fixes introduced in the new version. However, it is necessary to ensure that the new version doesn't introduce breaking changes. It's recommended to test the workflow with the updated action to confirm that everything still functions as expected. Furthermore, updating the comment from '# v3' to '# v4' could provide better documentation about the current version of the used action.

Copy link

@codecov codecov bot Jun 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using a specific commit hash to reference the setup-pdm repository. Using a specific commit hash protects against unexpected changes, but it also means you won't automatically receive updates. As this commit represents a version update, it's crucial to confirm that version 4 of the pdm-project/setup-pdm repository supports all existing project features and doesn't introduce any new bugs or performance issues.

with:
python-version: ${{ matrix.python-version }}

Expand Down
Loading