Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lobby list #839

Merged
merged 16 commits into from
Mar 24, 2021
Merged

Lobby list #839

merged 16 commits into from
Mar 24, 2021

Conversation

drazisil
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #839 (da3724f) into main (c9732a8) will decrease coverage by 56.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #839       +/-   ##
==========================================
- Coverage   56.11%   0.00%   -56.12%     
==========================================
  Files          22      40       +18     
  Lines        1071    1572      +501     
  Branches       46      86       +40     
==========================================
- Hits          601       0      -601     
- Misses        459    1572     +1113     
+ Partials       11       0       -11     
Impacted Files Coverage Δ
launch.js 0.00% <0.00%> (ø)
src/services/AdminServer/AdminServer.ts 0.00% <0.00%> (-40.00%) ⬇️
src/services/AuthLogin/AuthLogin.ts 0.00% <0.00%> (ø)
src/services/MCServer/ClientConnectMsg.ts 0.00% <0.00%> (-82.61%) ⬇️
src/services/MCServer/ConnectionMgr.ts 0.00% <0.00%> (ø)
src/services/MCServer/ConnectionObj.ts 0.00% <0.00%> (-69.57%) ⬇️
src/services/MCServer/EncryptionMgr.ts 0.00% <0.00%> (ø)
src/services/MCServer/GenericReplyMsg.ts 0.00% <0.00%> (-71.06%) ⬇️
src/services/MCServer/GenericRequestMsg.ts 0.00% <0.00%> (-76.00%) ⬇️
src/services/MCServer/LobbyServer/LobbyServer.ts 0.00% <0.00%> (-27.44%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9732a8...da3724f. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Mar 21, 2021

This pull request introduces 1 alert when merging ebfa943 into c9732a8 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

need to start fresh again
@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request introduces 1 alert when merging 8c1da39 into c9732a8 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request introduces 1 alert when merging 69d9006 into c9732a8 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

@lgtm-com
Copy link

lgtm-com bot commented Mar 24, 2021

This pull request introduces 1 alert when merging 8470041 into c9732a8 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

@ghost
Copy link

ghost commented Mar 24, 2021

Congratulations 🎉. DeepCode analyzed your code in 13.021 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@drazisil
Copy link
Collaborator Author

Broken coverage due to merging main

@drazisil drazisil merged commit ebe3335 into main Mar 24, 2021
@drazisil drazisil deleted the lobby-list branch March 24, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant