feat(test): Add a new test to ensure proper signature checking #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
force-pushed
the
macros/verify-signature-announcement_signatures
branch
from
d7b7e89
to
ffaa96f
Compare
Fixes a bug in lnprototest by removing the problematic code outlined in patch [1]. During our investigation of the cln code, we discovered that the message verification was not performed correctly as the BOL 7 suggest. This commit includes a patch [2] that fixes the issue and introduces an integration test to validate that core lightning adheres to the signature verification guidelines outlined in BOLT7. [1] #91 [2] ElementsProject/lightning#6384 Reported-by: lnprototest (#91) Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/verify-signature-announcement_signatures
branch
from
ba026c3
to
c518325
Compare
vincenzopalazzo
force-pushed
the
macros/verify-signature-announcement_signatures
branch
from
c518325
to
ecc260a
Compare
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Jul 15, 2023
This update incorporates the proposed version of lnprototest from the patch [1], which includes the following fixes: - Corrects the `ExpectError` event and updates BOLT 7 to expect a warning instead of an error. - Implements a new test for when the runner sends a bad signature within the announcement_signatures message. [1] rustyrussell/lnprototest#100 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Jul 15, 2023
This update incorporates the proposed version of lnprototest from the patch [1], which includes the following fixes: - Corrects the `ExpectError` event and updates BOLT 7 to expect a warning instead of an error. - Implements a new test for when the runner sends a bad signature within the announcement_signatures message. [1] rustyrussell/lnprototest#100 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Jul 25, 2023
This update incorporates the proposed version of lnprototest from the patch [1], which includes the following fixes: - Corrects the `ExpectError` event and updates BOLT 7 to expect a warning instead of an error. - Implements a new test for when the runner sends a bad signature within the announcement_signatures message. [1] rustyrussell/lnprototest#100 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Jul 25, 2023
This update incorporates the proposed version of lnprototest from the patch [1], which includes the following fixes: - Corrects the `ExpectError` event and updates BOLT 7 to expect a warning instead of an error. - Implements a new test for when the runner sends a bad signature within the announcement_signatures message. [1] rustyrussell/lnprototest#100 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
Jul 25, 2023
This update incorporates the proposed version of lnprototest from the patch [1], which includes the following fixes: - Corrects the `ExpectError` event and updates BOLT 7 to expect a warning instead of an error. - Implements a new test for when the runner sends a bad signature within the announcement_signatures message. [1] rustyrussell/lnprototest#100 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
rustyrussell
pushed a commit
to ElementsProject/lightning
that referenced
this pull request
Jul 25, 2023
This update incorporates the proposed version of lnprototest from the patch [1], which includes the following fixes: - Corrects the `ExpectError` event and updates BOLT 7 to expect a warning instead of an error. - Implements a new test for when the runner sends a bad signature within the announcement_signatures message. [1] rustyrussell/lnprototest#100 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
|
Merging now that cln contains the feature ElementsProject/lightning#6384 |
vincenzopalazzo
deleted the
macros/verify-signature-announcement_signatures
branch
ddustin
pushed a commit
to ddustin/lightning
that referenced
this pull request
Jul 26, 2023
This update incorporates the proposed version of lnprototest from the patch [1], which includes the following fixes: - Corrects the `ExpectError` event and updates BOLT 7 to expect a warning instead of an error. - Implements a new test for when the runner sends a bad signature within the announcement_signatures message. [1] rustyrussell/lnprototest#100 Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in lnprototest by removing the problematic code outlined in patch [1].
During our investigation of the cln code, we discovered that the message verification was not performed correctly as the BOL 7 suggest. This commit includes a patch [2] that fixes the issue and introduces an integration test to validate that core lightning adheres to the signature verification guidelines outlined in BOLT7.
[1] #91
[2] ElementsProject/lightning#6384
Reported-by: lnprototest (#91)
P.S: now the integration testing should fails because the patch in core lightning is still open