Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: add fallback for ripemd160 implementation #59

Merged

Conversation

niftynei
Copy link
Collaborator

@niftynei niftynei commented Sep 8, 2022

OpenSSL removed ripemd160, which impacts the default impl of hashlib for most python installs (true as of 22.04 LTS).

While we're here, let's update to the newest libs for everything, which requires also updating some of the tests.

See also:

@vincenzopalazzo
Copy link
Collaborator

Other than I trivial formatting error that you can solve by run make fmt, there is this dependencies resolution that looks like is coming from cln

Removing intermediate container c8a8e4fe6d05
 ---> 0aa81a0abf16
Step 14/19 : RUN git config --global user.name "John Doe" && 	git config --global user.email johndoe@example.com && 	git clone https://github.com/ElementsProject/lightning.git &&     cd lightning && 	git pull origin pull/5367/head &&     poetry config virtualenvs.create false &&     poetry install &&     ./configure --enable-developer &&     make -j$(nproc)
 ---> Running in 78e16ad566af
Cloning into 'lightning'...
From https://github.com/ElementsProject/lightning
 * branch                refs/pull/5367/head -> FETCH_HEAD
Auto-merging lightningd/dual_open_control.c
Merge made by the 'recursive' strategy.
/usr/lib/python3/dist-packages/requests/__init__.py:89: RequestsDependencyWarning: urllib3 (1.26.12) or chardet (3.0.4) doesn't match a supported version!
  warnings.warn("urllib3 ({}) or chardet ({}) doesn't match a supported "

No module named 'virtualenv.seed.wheels'
The command '/bin/sh -c git config --global user.name "John Doe" && 	git config --global user.email johndoe@example.com && 	git clone https://github.com/ElementsProject/lightning.git &&     cd lightning && 	git pull origin pull/5367/head &&     poetry config virtualenvs.create false &&     poetry install &&     ./configure --enable-developer &&     make -j$(nproc)' returned a non-zero code: 1

OpenSSL removed ripemd160, which impacts the default impl of hashlib for
most python installs (true as of 22.04 LTS)

See also:

- openssl/openssl#16994
- bitcoin/bitcoin#23710
- petertodd/python-bitcoinlib#277
I did some stats analysis a while ago, I think the odds at 14 runs of a
fail is as statistically signficant as 20? Sorry, don't remember the
math.
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9a04513

lnprototest/runner.py Show resolved Hide resolved
@vincenzopalazzo vincenzopalazzo merged commit 32df9ee into rustyrussell:master Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants