-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openssl: add fallback for ripemd160 implementation #59
Merged
vincenzopalazzo
merged 7 commits into
rustyrussell:master
from
niftynei:nifty/ripemd160-fallback
Sep 10, 2022
Merged
openssl: add fallback for ripemd160 implementation #59
vincenzopalazzo
merged 7 commits into
rustyrussell:master
from
niftynei:nifty/ripemd160-fallback
Sep 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/ripemd160-fallback
branch
from
September 8, 2022 01:45
2101ecf
to
e87a43d
Compare
Other than I trivial formatting error that you can solve by run
|
OpenSSL removed ripemd160, which impacts the default impl of hashlib for most python installs (true as of 22.04 LTS) See also: - openssl/openssl#16994 - bitcoin/bitcoin#23710 - petertodd/python-bitcoinlib#277
I did some stats analysis a while ago, I think the odds at 14 runs of a fail is as statistically signficant as 20? Sorry, don't remember the math.
niftynei
force-pushed
the
nifty/ripemd160-fallback
branch
from
September 9, 2022 23:10
3d2c4f0
to
9a04513
Compare
vincenzopalazzo
approved these changes
Sep 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 9a04513
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL removed ripemd160, which impacts the default impl of hashlib for most python installs (true as of 22.04 LTS).
While we're here, let's update to the newest libs for everything, which requires also updating some of the tests.
See also: