This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
Add persistent per request degradation on failure #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bad things with redis happens, it raises a lot of Timeout or Connection error. If DEGRADE_ON_FAILURE is enabled, django goes to database after every error and can get its data anyway. But for every db request it does three (and even four if redisreplica is used) queries: two for asking replica and master for a cached data, one for getting data from db, and another one for saving cache.
In this fix client will be marked as degraded if Timeout or Connection error happens. After that no queries will be executed by this client during current request. So in case which described above we will have only three queries per first fetch (asking replica and master for cached data and getting data from db), and we won't try to ask cacheops for all next queries untill request won't be finished.
It's disabled by default and can be enabled by setting CACHEOPS_DEGRADE_PERSISTENT_PER_REQUEST flag to True.