Add S24_LE wav files and tests

[fletcherw]

The second patch in the series gets read_wav_wave_format_extensible_pcm_24bit_4byte() to pass, but the other test will need some deeper changes to work (potentially adding a frame size field which is block_align / num_channels ?)

[ruuda]

Thanks! This looks good to me so far.

the other test will need some deeper changes to work (potentially adding a frame size field which is block_align / num_channels ?)

WavSpecEx already has a bytes_per_sample field, and as you show that works out with WAVEFORMATEXTENSIBLE. I think what we can do is relax the check you mentioned earlier, and then pass the number of bytes per sample down into these methods that construct the WavSpecExc:

hound/src/read.rs

Lines 511 to 514 in 10673f8

	PCM => self.read_wave_format_pcm(chunk_len, spec),
	ADPCM => Err(Error::Unsupported),
	IEEE_FLOAT => self.read_wave_format_ieee_float(chunk_len, spec),
	EXTENSIBLE => self.read_wave_format_extensible(chunk_len, spec),

Or we could even already construct the WavSpecEx in read_fmt_chunk; all three read_wave_format_* methods set bytes_per_sample to spec.bits_per_sample / 8 anyway. We would set it to block_align / n_channels instead now.

Do you want to add that to this pull request?

[fletcherw]

Got both tests passing. I wasn't sure what your format preferences were, since it seems like you're not using cargo fmt generally. I just ran it on the lines that I modified, hopefully that looks good to you. I'm going to take a look at writing relatively soon as well.

[fletcherw]

Fixed some build errors on old rust.

[ruuda]

Got both tests passing. I wasn't sure what your format preferences were, since it seems like you're not using cargo fmt generally. I just ran it on the lines that I modified, hopefully that looks good to you.

I don’t have a strong preference on formatting, it looks good to me. Thanks for only formatting the modified lines and not the entire file.

[ruuda]

Looks good to me, thanks for implementing this!