Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wasm support #12

Merged
merged 1 commit into from
May 15, 2023
Merged

Add Wasm support #12

merged 1 commit into from
May 15, 2023

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented May 13, 2023

This adds support for the wasm32-unknown-unknown target.

When cfg(target_feature = "atomics") is not active, it will always return 0, which is appropriate, considering that without it you can't spawn threads.

Support for wasm32-unknown-emscripten could be added via pthreads, but I'm not qualified to do that.
WASI support cannot be added at the moment, as the wasm32-wasi-threads target doesn't exist yet.

Fixes #10.

@daxpedda
Copy link
Contributor Author

daxpedda commented May 13, 2023

Restarting CI, spurious network errors ...

@daxpedda daxpedda closed this May 13, 2023
@daxpedda daxpedda reopened this May 13, 2023
@daxpedda
Copy link
Contributor Author

Still just spurious network errors on CI.

In any case, the PR is fine, it shouldn't affect the CI at all.

@ruuda
Copy link
Owner

ruuda commented May 15, 2023

Ah yes, CI … last time I needed to release a new version of this crate, Travis CI still existed 😅 I’ll try to migrate this to GitHub Actions.

@daxpedda
Copy link
Contributor Author

Thanks for restarting, it almost worked this time, only one spurious network error 😆!

I’ll try to migrate this to GitHub Actions.

Let me know if you need any help!

@ruuda
Copy link
Owner

ruuda commented May 15, 2023

Thanks for restarting, it almost worked this time, only one spurious network error

I had to restart it four or five times to get all of them to pass, I wonder what is causing it. But anyway, this change looks good, thanks a lot! I’ll get CI sorted out and then publish a new release.

@ruuda ruuda merged commit 059f913 into ruuda:master May 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error[E0425]: cannot find function get_internal in this scope when compiling to WASM
2 participants