Moved readOnly check to GraphNavigator

ruudk · Mar 8, 2012 · c4bdee4 · c4bdee4
1 parent 33568ff
commit c4bdee4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/Serializer/GenericDeserializationVisitor.php b/Serializer/GenericDeserializationVisitor.php
@@ -173,10 +173,6 @@ public function visitProperty(PropertyMetadata $metadata, $data)
             return;
         }
 
-        if ($metadata->readOnly) {
-	        return;
-	    }
-
         if (!$metadata->type) {
             throw new RuntimeException(sprintf('You must define a type for %s::$%s.', $metadata->reflection->getDeclaringClass()->getName(), $metadata->name));
         }

diff --git a/Serializer/GraphNavigator.php b/Serializer/GraphNavigator.php
@@ -114,6 +114,10 @@ public function accept($data, $type, VisitorInterface $visitor)
                     continue;
                 }
 
+		        if (self::DIRECTION_DESERIALIZATION === $this->direction && $propertyMetadata->readOnly) {
+			        continue;
+			    }
+
                 // try custom handler
                 if (!$visitor->visitPropertyUsingCustomHandler($propertyMetadata, $data)) {
                     $visitor->visitProperty($propertyMetadata, $data);

diff --git a/Serializer/XmlDeserializationVisitor.php b/Serializer/XmlDeserializationVisitor.php
@@ -196,11 +196,7 @@ public function startVisitingObject(ClassMetadata $metadata, $data, $type)
     public function visitProperty(PropertyMetadata $metadata, $data)
     {
         $name = $this->namingStrategy->translateName($metadata);
-
-        if ($metadata->readOnly) {
-	        return;
-	    }
-
+
         if (!$metadata->type) {
             throw new RuntimeException(sprintf('You must define a type for %s::$%s.', $metadata->reflection->getDeclaringClass()->getName(), $metadata->name));
         }