fix remapper $HOME path #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,6 +40,8 @@ sudo cp $HOME/bthidhub/install/on_rpi/sdp_record.xml /etc/bluetooth/sdp_record.x | |||
| sudo cp $HOME/bthidhub/install/on_rpi/input.conf /etc/bluetooth/input.conf | |||
| sudo cp $HOME/bthidhub/install/on_rpi/main.conf /etc/bluetooth/main.conf | |||
|
|
|||
| sudo sed -i "s/\/home\/pi/\/home\/$(basename $HOME)/g" $HOME/bthidhub/install/on_rpi/remapper.service | |||
There was a problem hiding this comment.
Perhaps it'd be a little safer to just put {PI_USER} in the service file and replace that?
Also, I'd rather edit the copied file than end up with uncommitted changes in the repo (i.e. regular UI improvements can be upgraded with git pull if the repo contents are not modified).
| @@ -40,6 +40,8 @@ sudo cp $HOME/bthidhub/install/on_rpi/sdp_record.xml /etc/bluetooth/sdp_record.x | |||
| sudo cp $HOME/bthidhub/install/on_rpi/input.conf /etc/bluetooth/input.conf | |||
| sudo cp $HOME/bthidhub/install/on_rpi/main.conf /etc/bluetooth/main.conf | |||
|
|
|||
| sudo sed -i "s/\/home\/pi/\/home\/$(basename $HOME)/g" $HOME/bthidhub/install/on_rpi/remapper.service | |||
| sudo sed -i "s/PI_USER = 'pi'/PI_USER = '$(basename $HOME)'/g" $HOME/bthidhub/web.py | |||
There was a problem hiding this comment.
Same with uncommitted change in this file. At worst, we could write a new file and have the code read the user from that file. Maybe a better approach would be to pass the user in the service file to the application?
|
Feel free to separate the revised changes into 2 PRs, in order to get them merged quicker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a replace to fix remapper.service on different users