Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate samples from the exported CSV #638

Closed
priyonto opened this issue Mar 24, 2022 · 6 comments
Closed

Remove duplicate samples from the exported CSV #638

priyonto opened this issue Mar 24, 2022 · 6 comments
Labels
4h bug
Milestone
1.8

Comments

@priyonto
Copy link

Exported CSV file of the tags contains duplicate samples.

Screenshot 2022-03-24 at 10 48 04 AM

File: Tag_20220324-1201.csv
@andreevdenis andreevdenis self-assigned this Mar 24, 2022
@andreevdenis andreevdenis added this to the 1.8 milestone Mar 25, 2022
andreevdenis added a commit that referenced this issue Mar 25, 2022
@andreevdenis
ISSUE #638 Remove duplicate samples from the exported CSV
198a08b 
[FIXED] cloud sync to avoid duplicates
andreevdenis added a commit that referenced this issue Mar 25, 2022
@andreevdenis
Merge pull request #640 from ruuvi/issue/638_sync_duplicates
8399284 
ISSUE #638 Remove duplicate samples from the exported CSV
@andreevdenis
Copy link
Collaborator

The issue was with cloud sync. I was requesting data from last sync time and previously synced last point was included into new response. Now requesting from last sync time + 1 second.

@andreevdenis
Copy link
Collaborator

1.8.2

@priyonto
Copy link
Author

Thank you @andreevdenis for quickly looking into it. I will check it again on 1.8.2.

@andreevdenis
Copy link
Collaborator

Previously synced duplicates will stay in app unless you sign out and sign in again.

@priyonto
Copy link
Author

Yes, that's understandable.

@markoaamunkajo
Copy link
Collaborator

QA passed

@markoaamunkajo markoaamunkajo removed their assignment Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4h bug
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
3 participants
@priyonto @andreevdenis @markoaamunkajo