Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat support external tmp117 #337

Merged
merged 25 commits into from Mar 13, 2024
Merged

Feat support external tmp117 #337

merged 25 commits into from Mar 13, 2024

Conversation

ojousima
Copy link
Member

No description provided.

@reviewpad reviewpad bot added the small Pull request is small label Mar 18, 2023
@reviewpad reviewpad bot requested a review from laurijamsa March 18, 2023 13:12
@reviewpad
Copy link
Contributor

reviewpad bot commented Mar 18, 2023 •
edited

Reviewpad Report

‼️ Errors

  • Unconventional commit detected: 'Update actions' (3bb54ed)
  • Unconventional commit detected: 'Fix uses-caluse' (c207eac)
  • Unconventional commit detected: 'Merge branch 'master' into feat-support-external-tmp117' (3d5bbc9)
  • Unconventional commit detected: 'Remove PVS' (3ecb702)
  • Unconventional commit detected: 'update submodules, actions' (a4cb78a)
  • Unconventional commit detected: 'Fix ceedling in Jenkinsfile' (aed5414)
  • Unconventional commit detected: 'Update tests' (ed3c2d3)
  • Unconventional commit detected: 'Update tests with external tmp' (1136d32)
  • Unconventional commit detected: 'Measure for every tx in LL' (174e827)
  • Unconventional commit detected: 'Lower measurement freq in LL, add Jenkins deploy step' (b13a4b7)
  • Unconventional commit detected: 'Fix acceleration threshold' (594a00a)
  • Unconventional commit detected: 'Add flash protect function' (6da4bd2)
  • Unconventional commit detected: 'AStyle' (4ca5743)
  • Unconventional title detected: 'Feat support external tmp117' expecting colon (':') character, got ' ' character: col=04

⚠️ Warnings

  • Please link an issue to the pull request
  • Please provide a description for the pull request
  • Please rebase your pull request on the latest changes

@reviewpad reviewpad bot added medium Pull request is medium and removed small Pull request is small labels Mar 18, 2023
@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Mar 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ojousima ojousima merged commit b483257 into master Mar 13, 2024
5 checks passed
@ojousima ojousima deleted the feat-support-external-tmp117 branch March 13, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurijamsa laurijamsa Awaiting requested review from laurijamsa

Assignees
No one assigned
Labels
large Pull request is large waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ojousima