Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config provider #7

Open
drochag opened this issue Jun 2, 2015 · 6 comments
Open

Add config provider #7

drochag opened this issue Jun 2, 2015 · 6 comments

Comments

@drochag
Copy link
Collaborator

drochag commented Jun 2, 2015

Add a simpleSliderConfigProvider with defaults for every slider created through the directive

@ruyadorno
Copy link
Owner

I'm afraid this may be a bit of an overkill for such a simple directive... but if anyone is willing to give it a try I would be happy to help reviewing it :)

@ruyadorno
Copy link
Owner

@danmmx I see you're really interested in this project so I added you as a collaborator to this repo 😄

👍 feel free to help me review/merge future PRs

@drochag
Copy link
Collaborator Author

drochag commented Jun 3, 2015

Thanks a lot @ruyadorno I'll try to do it asap, my interest is mostly because I'm using this one side project I'm working on, will share you the link when it's ready.

The reason for this enhancement proposal is because I have the following same markup in several places :


    .SliderBlock-slider(
        simple-slider,
        start-value='0',
        end-value='0',
        visible-value='1',
        transition-property='opacity',
        transition-duration='2',
        transition-delay='5'
    )
        div.SliderBlock-image(ng-repeat='image in event.Images', ng-style='imageBackground(image.name)')
            .SliderBlock-backgroundOverlay

and would like it to reduce it to


    .SliderBlock-slider(simple-slider)
        div.SliderBlock-image(ng-repeat='image in event.Images', ng-style='imageBackground(image.name)')
            .SliderBlock-backgroundOverlay

and it can be done with config defaults on the config run on Angular

@ruyadorno
Copy link
Owner

hmmmm, got it! 👍 makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@ruyadorno @drochag and others