Slide binding. It now accepts onChange

[drochag]

4 mayor changes:

• onClick acceptance through latest SimpleSlider dist files.
• slider double binding so any outer scope can access directly to the SimpleSlider API
• slider's slide double binding so more natural angular digest happens
• directive now waits until dynamic children are loaded

[ruyadorno]

I would like to see a better attribute name for the slide attribute, actual-slide or current-slide are definitely better

[ruyadorno]

Many thanks @danmmx ! 😄

These are awesome ideas and fixes! I'm taking the time to comment on a few things and let's get it merged :)

[drochag]

Good to know @ruyadorno ^_^ let me know when you finished commenting so we don't overlap changes + comments.

[ruyadorno]

I have to confess that my angular skills are a bit rusty these days, so help me out with this one.

Is it really a good idea to expose the SimpleSlider object as a simple-slider attribute?

My original idea was to hide everything behind the directive implementation and the consumer would just play with the attributes. I don't really know what are the trade-offs involved here. Since you're already exposing onchange and the simple-slider-slide attribute it seems that it would make sense to keep the consumers away from the simpleSlider instance, have you give it some thought? I would love to have some feedback 😊

[ruyadorno]

Looking awesome 😄 I'm done with reviews, just the watcher var renaming and we're good to go

[drochag]

I think it's ready @ruyadorno 👍

[ruyadorno]

👍 LGTM