Leak #12
Merged
Leak #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manifest tests complaint otherwise and these files never should be shipped to CPAN.
Because of Git::Commit and it is documented in the plugin's docs.
The former is deprecated
0.52 release was never placed into Changes, copy date from CPAN.
If we don't do this we leak CGI::PSGI instance per request and other object referenced by it, but only if plack's response_cb util is used. I couldn't unwrap everything to find particular reason of the leak, but this change helps. Test proves that module leaks without the change and doesn't leak with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's my ultimate goal at the moment to merge this and release a new version. Because of Changes file it's based on top of releng-fixes branch (sent pull request a few minutes ago) and should be merged after.
I can take care of release if you give me co-maint.