This repository has been archived by the owner on Apr 5, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This reverts commit 4c73781.
@rvagg, any thoughts? |
only thought is that I'm glad someone else has time for this! added you as collaborator and npm owner, |
@rvagg, cool. I'll get something in npm soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a full rewrite on top of the current leveldown codebase.
It passes all current leveldown tests aside from a few I've removed: some LevelDB-specific ones (i.e. compression). The tests that are really failing are the null key/value tests -- I've turned null values into single null bytes (
{0}
) instead of empty buffers (LMDB doesn't allow for empty values). So, all in all 5 tests are failing, but for technical edge-case reasons.New additions/changes:
iterator.seek()
has been implemented.getProperty
.leveldown.destroy()
has been implemented.sync
option has been implemented for put/del/batch.notls
has been fixed.New features:
db.backup(path, callback);
.noSubdir
option.Todo:
Upgrade LMDB itself.Implementleveldown.destroy().
s/leveldown/nlmdb/g
Hopefully, now we that we have the code in sync with the latest leveldown code, we can maintain this module more easily. I plan on using this module in production eventually, so I'll definitely be around to care about it.
cc @rvagg