Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would it be possible to add readIntBE and readIntLE? #54

Closed
ctusch opened this issue Apr 25, 2018 · 3 comments
Closed

Would it be possible to add readIntBE and readIntLE? #54

ctusch opened this issue Apr 25, 2018 · 3 comments

Comments

@ctusch
Copy link
Contributor

ctusch commented Apr 25, 2018

I'm using readIntBE on a Buffer and was trying to change it to BufferList only to notice that this method is not supported yet. Would it be possible to add it?
@rvagg
Copy link
Owner

rvagg commented Apr 26, 2018 •
edited
Loading

yeah, I guess the original API was formed during Node 0.10 when we didn't have those, please open a PR and I think we can make it happen

@ctusch ctusch mentioned this issue Apr 26, 2018
Merged
@ctusch
Copy link
Contributor Author

ctusch commented Apr 26, 2018

I've opened a PR but the tests fail for node 0.10. As you've said, back then those methods weren't implemented. How should we move forward?

@ctusch
Copy link
Contributor Author

ctusch commented May 15, 2018

The pull request has been merged and node 0.10 support will be dropped. :)

@ctusch ctusch closed this as completed May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rvagg @ctusch