Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate issue with split index #54

Closed
HendrikSchmidt opened this issue Oct 7, 2022 · 0 comments
Closed

Investigate issue with split index #54

HendrikSchmidt opened this issue Oct 7, 2022 · 0 comments

Comments

@HendrikSchmidt
Copy link
Collaborator

Atm StepHistorical leads to issues, because it sometimes drops the complete index. However, the splits are implemented as an index on the DF and so get lost as well/can't be lined up with the result.
This could also lead to problems when trying to do the following:

rec.prep(data=train_df)
rec.bake(data=val_df)
rec.bake(data=test_df)

Investigate if a different setup for the splits might make sense (e.g. dict with three keys, implies changing the dataloader too) or the HistoricalSteps (and maybe more preprocessing) need to be changed.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant