Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use binary search in t2length() and explicitly check for null and undefined in Bezier function #3

Merged
merged 2 commits into from Feb 15, 2017

Conversation

Rheeseyb
Copy link
Contributor

Use binary search in t2length() - proposed fix for #1

Explicitly check for null and undefined - proposed fix for #2

@Rheeseyb
Copy link
Contributor Author

Thanks for writing this library by the way!

I haven't checked the performance impact of switching to the binary search - anecdotally the tests didn't seem to take any longer.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.652% when pulling 3b00350 on momentumworks:master into 8af8f32 on rveciana:master.

@rveciana
Copy link
Owner

Thank you! I'll merge the request and then I'll try to write some tests to check it in the future

@rveciana rveciana merged commit a7ee981 into rveciana:master Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants