Add checking of keywords to make solve more robust, fix #166 #30
Conversation
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 86.29% 86.43% +0.13%
==========================================
Files 4 4
Lines 197 199 +2
==========================================
+ Hits 170 172 +2
Misses 27 27
Continue to review full report at Codecov.
|
src/common.jl
Outdated
| @@ -4,6 +4,8 @@ function solve{uType,tType,isinplace}( | |||
| prob::AbstractODEProblem{uType,tType,isinplace}, | |||
| alg::LSODAAlgorithm, | |||
| timeseries=[],ts=[],ks=[]; | |||
|
|
|||
| dense=false, verbose=true, | |||
There was a problem hiding this comment.
dense shouldn't be treated differently.
2 similar comments
|
Nice work. Note @rveltz that this actually requires a DiffEqBase tag, but it's already to merge earlier since instead of throwing a warning on an ignored keyword argument, pre-tag it will throw an error. We chose to go with warnings because technically the solution is still correct, but the user should know that some of what they think might be tweaked isn't actually tweaked. This is a clean solution that handles all of the keyword args. |
Add dtmin, dtmax to the list of checked keywords
|
OK, dtmin/dtmax added |
1 similar comment
No description provided.