Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Common Interface Bindings #5

Closed
wants to merge 2 commits into from

Conversation

ChrisRackauckas
Copy link
Collaborator

This adds LSODA to the common interface. For example, as seen in the tests, problems on things like 2-dimensional matrix are supported through solve:

using LSODA, DiffEqProblemLibrary
prob = prob_ode_2Dlinear
sol = solve(prob,LSODAAlg(),save_timeseries=false,saveat=[1/2])

Additionally, this allows LSODA to be the backend solver for sensitivity analysis, parameter estimation, etc.

Currently there are some details to fix up:

  • If the package is named LSODA, then the algorithm type cannot be named LSODA. This is a bummer. Currently I named it LSODAAlg. Is there a better name?
  • Setup with save_timeseries. Currently you can only use the saveat style of saving instead of letting it save at each timepoint it steps to. Can someone help me find out how to get the value of each timestep @sdwfrost ?

@coveralls
Copy link

coveralls commented Nov 27, 2016

Coverage Status

Coverage decreased (-38.6%) to 52.817% when pulling bcfdcdf on ChrisRackauckas:master into 913574f on rveltz:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-38.6%) to 52.817% when pulling bcfdcdf on ChrisRackauckas:master into 913574f on rveltz:master.

@ChrisRackauckas
Copy link
Collaborator Author

Switching the PR branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants