Bugfix: doesn't returns all links #50
Closed
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When searchSubdomain option is set, the program compare the new to base in order to determine if it is a sub domain. In the case we anamlyase a web site https://www.ozon.io/, we activate searchSubdomain and we encounter a relitive link /offers, we have this case: base = url.Parse("https://www.ozon.io/") ref = url.Parse("/offers") We compare the subdomains of base and ref, and they are always different because "ref" is not a absolute links. So https://www.ozon.io/offers is not returned as link, but it should be returned. This path propose compare the result of base.ResolveReference(ref) in place of ref. this solve the problem because base.ResolveReference set the right hostname in the result.
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searchSubdomain option is set, the program compare the new to base
in order to determine if it is a sub domain.
In the case we anamlyase a web site https://www.ozon.io/, we activate
searchSubdomain and we encounter a relitive link /offers, we have this
case:
base = url.Parse("https://www.ozon.io/")
ref = url.Parse("/offers")
We compare the subdomains of base and ref, and they are always different
because "ref" is not a absolute links. So https://www.ozon.io/offers is
not returned as link, but it should be returned.
This path propose compare the result of base.ResolveReference(ref) in place
of ref. this solve the problem because base.ResolveReference set the right
hostname in the result.