Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving handling of guards #105

Closed
rvirding opened this issue Jan 9, 2015 · 2 comments
Closed

Improving handling of guards #105

rvirding opened this issue Jan 9, 2015 · 2 comments

Comments

@rvirding
Copy link
Member

rvirding commented Jan 9, 2015

The LFE compiler handles guards correctly but not as efficiently as possible. One reason is that optimisation passes in the erlang compiler assume that things look exactly like they do from the erlang compiler otherwise they can sometimes do something wrong or even crash. For this reason I have turned off some optimisation passes.

What I plan to do now is rewrite some of the LFE compiler code generation pass to output more erlang compiler like code so I can, hopefully, turn on the optimisation again.

@oubiwann
Copy link
Member

oubiwann commented Jan 9, 2015

A note from the sidelines: This is insanely cool :-)

On Fri, Jan 9, 2015 at 9:32 AM, Robert Virding notifications@github.com
wrote:

The LFE compiler handles guards correctly but not as efficiently as
possible. One reason is that optimisation passes in the erlang compiler
assume that things look exactly like they do from the erlang compiler
otherwise they can sometimes do something wrong or even crash. For this
reason I have turned off some optimisation passes.

What I plan to do now is rewrite some of the LFE compiler code generation
pass to output more erlang compiler like code so I can, hopefully, turn on
the optimisation again.


Reply to this email directly or view it on GitHub
#105.

@oubiwann oubiwann added this to the 2.1 milestone Jun 7, 2021
@oubiwann oubiwann modified the milestones: 2.1, 2.2 Jan 17, 2023
@rvirding
Copy link
Member Author

This was fixed in this commit 5e6dc25 when we went over to the LFE compiler generating Erlang AST.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants