Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load hangs on no work #4

Closed
rviscomi opened this issue Oct 3, 2012 · 0 comments
Closed

Load hangs on no work #4

rviscomi opened this issue Oct 3, 2012 · 0 comments
Assignees
Labels
Milestone

Comments

@rviscomi
Copy link
Owner

rviscomi commented Oct 3, 2012

When there's no work to do, the app hangs during loading. This happens when a list of stargazers or locations is empty, and the loop is never executed. For example, a new user stars a repo but does not have a location defined. The locations array will be empty (assuming it was precached) and the app will hang.

Always check to see if the loop was skipped and handle the sentinel condition accordingly.

@ghost ghost assigned rviscomi Oct 3, 2012
rviscomi added a commit that referenced this issue Oct 3, 2012
- store less stargazer info (url, login)
- this.locations
- error handling
@rviscomi rviscomi closed this as completed Oct 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant