Add float_warnings patchsets for ruby 2.1.[67] and 2.2.[0123] #3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind update your commit message to be more descriptive on what this patchset does and maybe a link to any issue that you have ran into that made you created this patch? /cc @havenwood wdyt about this patch? |
|
Hi sikachu, just like previous PRs (https://github.com/rvm/rvm/pulls?q=is%3Apr+is%3Aclosed+author%3Aknugie) these patches are used to warn you whenever you want to instantiate a BigDecimal with an instance of Float, fmi see https://slides.com/wolfgangteuber/saving-money-with-ruby/fullscreen# and https://github.com/knugie/rvm-patchsets#rvm-patchsets-for-mri-ruby |
|
we already got 30 patches like this, merging |
mpapis
added a commit
that referenced
this pull request
Feb 25, 2016
Add float_warnings patchsets for ruby 2.1.[67] and 2.2.[0123]
|
👍 Thanks Michal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.